Skip to content

Improve deploy_windows.ps1 fetching of dependencies #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
softins wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve deploy_windows.ps1 fetching of dependencies #3612

softins wants to merge 2 commits into from
+13 −12

Conversation

@softins
Copy link
Member

@softins softins commented Jan 28, 2026 •
edited
Loading

Short description of changes

In deploy-windows.ps1, updated Install-Dependency to create a unique empty directory for unpacking the fetched zip file into, for ASIO and NSIS.

Also updated the regex for matching the ASIO file version in bump-dependencies.yml.

CHANGELOG: Build: Improve dependency fetching for Windows builds

Context: Fixes an issue?

Fixes #3560
Replaces #3607

This avoids having to know the top-level directory name used within the archive, which for ASIO is not consistent between versions, and could not be updated by bump-dependencies.yml

Does this change need documentation? What needs to be documented and how?

I don't think so. It just makes the PRs generated for updating ASIO and NSIS build properly.

Status of this Pull Request

Ready for review

What is missing until this pull request can be merged?

Check CI works

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors. (except iOS)
  • I've filled all the content above

@softins
Improve deploy_windows.ps1 fetching of dependencies
045b9c1 
Updated Install-Dependency to create a unique empty directory for
unpacking the fetched zip file into, for ASIO and NSIS.

This avoids having to know the top-level directory name used within
the archive, which for ASIO is not consistent between versions.
@softins softins mentioned this pull request Jan 28, 2026
Closed
5 tasks
@softins softins added this to the Release 3.12.0 milestone Jan 28, 2026
@softins softins added this to Tracking Jan 28, 2026
@github-project-automation github-project-automation bot moved this to Triage in Tracking Jan 28, 2026
@softins softins self-assigned this Jan 28, 2026
@softins softins requested review from ann0see and pljones January 28, 2026 17:39
pljones
pljones reviewed Jan 30, 2026
View reviewed changes
windows/deploy_windows.ps1
@@ -11,9 +11,7 @@ param (
#
# The following version pinnings are semi-automatically checked for
# updates. Verify .github/workflows/bump-dependencies.yaml when changing those manually:
Copy link
Collaborator

@pljones pljones Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will bump-dependencies be affected?

Copy link
Member Author

@softins softins Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think so, but just double-checking.

Copy link
Member Author

@softins softins Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs #3607 to be applied to bump-dependencies, but that is all.

Copy link
Member Author

@softins softins Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied that to a test branch, and ran the check-dependencies action. It ran fine: https://github.com/jamulussoftware/jamulus/actions/runs/21530391149
and created a good PR (although that also included the commits from this PR and for bump-dependencies). #3615

Copy link
Collaborator

@pljones pljones Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got three PRs to get this working? Can we have just one?

Copy link
Member Author

@softins softins Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, #3615 was just generated by the test run. I closed it, and it will be regenerated when the merge is up to date.

I'd be happy to incorporate the content of #3607 into this PR instead, so we just have this one.

Copy link
Collaborator

@pljones pljones Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense as they're all about sorting out the build for the Windows dependencies.

Copy link
Member Author

@softins softins Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, all done, and I've updated the description for this PR accordingly.

@softins
Allow new ASIO filename format
2c53690 
Make asiosdk or ASIO-SDK part of the version, so that URLs are correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pljones pljones pljones left review comments

@ann0see ann0see Awaiting requested review from ann0see

At least 2 approving reviews are required to merge this pull request.

Assignees

@softins softins

Labels

None yet

Projects

Tracking
Status: Triage

Milestone

Release 3.12.0

Development

Successfully merging this pull request may close these issues.

Update references to Steinberg ASIO SDK filename

2 participants

@softins @pljones