Skip to content

allow for the user to pass f_ref and eps#103

Merged
u-dupletsa merged 1 commit intojanosch314:mainfrom
u-dupletsa:main
Jan 14, 2025
Merged

allow for the user to pass f_ref and eps#103
u-dupletsa merged 1 commit intojanosch314:mainfrom
u-dupletsa:main

Conversation

@u-dupletsa
Copy link
Collaborator

  • allow user to pass f_ref (reference value is 50Hz as it was before)
  • allow user to pass derivative step; distinguish between eps and eps_mass, as mass parameters require a smaller step since they are precisely constrained
  • modified tutorial to include a note on the possibility to set the reference frequency and change f_ref value; added a small paragraph (at the end of the tutorial) about numerical derivative in gwfish and the size of eps

Copy link
Collaborator

@jacopok jacopok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@u-dupletsa u-dupletsa merged commit 8cdefbb into janosch314:main Jan 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants