allow for the user to pass f_ref and eps#103
Merged
u-dupletsa merged 1 commit intojanosch314:mainfrom Jan 14, 2025
Merged
Conversation
Collaborator
u-dupletsa
commented
Jan 13, 2025
- allow user to pass f_ref (reference value is 50Hz as it was before)
- allow user to pass derivative step; distinguish between eps and eps_mass, as mass parameters require a smaller step since they are precisely constrained
- modified tutorial to include a note on the possibility to set the reference frequency and change f_ref value; added a small paragraph (at the end of the tutorial) about numerical derivative in gwfish and the size of eps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.