Skip to content

Conversation

@jaypatrick
Copy link
Owner

Add additional exclusions to both lint and fmt configurations to prevent
checking non-source files that may cause false failures:

  • prisma/: Prisma schema files
  • docs/: Documentation files
  • .github/: GitHub workflows and templates
  • *.lock: Lock files (deno.lock, pnpm-lock.yaml, package-lock.json)
  • *.lcov: Coverage report files
  • *.d.ts: Auto-generated TypeScript declaration files

Add additional exclusions to both lint and fmt configurations to prevent
checking non-source files that may cause false failures:

- prisma/: Prisma schema files
- docs/: Documentation files
- .github/: GitHub workflows and templates
- *.lock: Lock files (deno.lock, pnpm-lock.yaml, package-lock.json)
- *.lcov: Coverage report files
- *.d.ts: Auto-generated TypeScript declaration files
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 13, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
adblock-compiler c314ea1 Jan 13 2026, 10:01 AM

@jaypatrick jaypatrick requested a review from Copilot January 13, 2026 10:01
@github-actions
Copy link

Version bumped: 0.7.13 -> 0.7.14

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the lint and format exclude patterns in deno.json to prevent checking non-source files that may cause false failures, and bumps the version from 0.7.13 to 0.7.14 across the project.

Changes:

  • Added exclusions for prisma/, docs/, .github/, and *.d.ts files to both lint and fmt configurations
  • Added exclusions for *.lock and *.lcov files to fmt configuration only
  • Updated version number from 0.7.13 to 0.7.14 in all version-related files

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
deno.json Added exclude patterns for prisma/, docs/, .github/, *.d.ts to lint config; added same patterns plus *.lock and *.lcov to fmt config; bumped version to 0.7.14
src/version.ts Updated VERSION constant from 0.7.13 to 0.7.14
package.json Updated version field from 0.7.13 to 0.7.14
wrangler.toml Updated COMPILER_VERSION environment variable from 0.7.13 to 0.7.14
examples/cloudflare-worker/wrangler.toml Updated COMPILER_VERSION environment variable from 0.7.13 to 0.7.14
examples/cloudflare-worker/package.json Updated version field from 0.7.13 to 0.7.14
docker-compose.yml Updated COMPILER_VERSION environment variable from 0.7.13 to 0.7.14

"examples/",
"prisma/",
"docs/",
".github/",
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint exclude section is missing the *.lock and *.lcov patterns that were added to the fmt exclude section. While Deno's linter may not attempt to lint these file types by default, it would be more consistent and defensive to exclude them explicitly from both lint and fmt configurations to prevent potential issues if the linter behavior changes or if these patterns match files with different extensions in the future.

Suggested change
".github/",
".github/",
"*.lock",
"*.lcov",

Copilot uses AI. Check for mistakes.
@jaypatrick
Copy link
Owner Author

@copilot open a new pull request to apply changes based on the comments in this thread

Copy link

Copilot AI commented Jan 13, 2026

@jaypatrick I've opened a new pull request, #129, to work on those changes. Once the pull request is ready, I'll request review from you.

@jaypatrick jaypatrick merged commit 06db084 into master Jan 13, 2026
7 checks passed
@jaypatrick jaypatrick deleted the claude/fix-linting-format-check-YtNp0 branch January 13, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants