Skip to content

Comments

Softcoding APNS timeout#772

Open
goinnn wants to merge 1 commit intojazzband:masterfrom
we-are-Joinup:apns-timeout
Open

Softcoding APNS timeout#772
goinnn wants to merge 1 commit intojazzband:masterfrom
we-are-Joinup:apns-timeout

Conversation

@goinnn
Copy link
Member

@goinnn goinnn commented Jun 3, 2025

Setting a timeout for requests is crucial to prevent an application from hanging indefinitely while waiting for a response. It enhances system resilience by allowing detection of failures or slowdowns in external services. Additionally, having a configurable timeout makes it adaptable to different performance and reliability needs.

@goinnn goinnn mentioned this pull request Jun 3, 2025
Copy link
Member

@50-Course 50-Course left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @goinnn, thanks for this patch. truly helpful we should roll this out as soon as possible with relevant updates.

@50-Course
Copy link
Member

@goinnn can you please take a look at the conflicts? this should have gone in long ago, was expecting to see some other approvals before it goes in. Thank you for your contributions to help make this better for everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants