[WIP] introduce dark background toggle, rework icons#66
Open
juliangaal wants to merge 2 commits intojbehley:masterfrom
Open
[WIP] introduce dark background toggle, rework icons#66juliangaal wants to merge 2 commits intojbehley:masterfrom
juliangaal wants to merge 2 commits intojbehley:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented your suggestions from #64. I also took the liberty to change the image icon, add a screenshot icon and toggle dark background"-icon. If you don't agree with this choice, no problem.
The pull request is marked WIP because of one issue: I tried making the binary independent of location, to fix #28 based on this comment. I did this by using the cmake variable
ASSETS_PATH, and loading the assets by converting this macro into filepaths inMainframe.cpp.This fixed #28, but labels are still not loaded when the GUI is started from anywhere outside
point_labeler/bin. According to my debugger, the label files paths are correctly loaded, yet the labels are not shown and the scans remain colored gray. Is this issue worth fixing, and/or where do you think additional changes need to be made to load the labels?Lastly, where did you get your icons from? I obeyed the license, and gave attribution to the authors, as seen at the end of the README