Add check/3, parse_and_check/3, and complete test cases#25
Open
saleyn wants to merge 5 commits intojcomellas:masterfrom
Open
Add check/3, parse_and_check/3, and complete test cases#25saleyn wants to merge 5 commits intojcomellas:masterfrom
saleyn wants to merge 5 commits intojcomellas:masterfrom
Conversation
The functions now allow to specify options:
[help | {skip, [Name::atom()]}]
help - instructs getopt:check/3 to return 'help'
when "-h" command line option is given and
option specification contains definition of 'help'.
This is needed to short-circuit the checker of
required options when help is requested.
{skip, Names} - tells the checker to skip checking given options
Added test cases for format_error/2 and the new functions mentioned above
Contributor
Author
|
ping |
1 similar comment
|
ping |
Owner
|
I'm not sure I like this completely. Let me analyze it for a bit and I will have a response tomorrow. |
Contributor
Author
|
Did you get a chance to look at the patch? |
|
ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions now allow to specify options:
[help | {skip, [Name::atom()]}]
Added test cases for format_error/2 and the new functions mentioned above