[issue26] Fix wrong assumption in splits equality#27
Open
Martin1887 wants to merge 1 commit intojendrikseipp:scorpionfrom
Open
[issue26] Fix wrong assumption in splits equality#27Martin1887 wants to merge 1 commit intojendrikseipp:scorpionfrom
Martin1887 wants to merge 1 commit intojendrikseipp:scorpionfrom
Conversation
A `values` of size 1 does not mean that the abstract state consists of 2 values in such variable. Fixes jendrikseipp#26
jendrikseipp
reviewed
Feb 7, 2026
| // subset of the state (the wanted values) may be even only one | ||
| // value (e.g., a precondition), so we cannot know if we are | ||
| // separating two values and so the order (`value` and `values`) | ||
| // matters. |
Owner
There was a problem hiding this comment.
If you're right and my code is incorrect, then we should simplify the whole if-statement to
Suggested change
| // matters. | |
| return value == other.value && values == other.values; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
valuesof size 1 does not mean that the abstract state consists of 2 values in such variable.Fixes #26