Fix cost saturation version of pho excluding abstractions that contain dead end information#28
Merged
jendrikseipp merged 2 commits intojendrikseipp:scorpionfrom Mar 4, 2026
Conversation
jendrikseipp
requested changes
Mar 4, 2026
Owner
jendrikseipp
left a comment
jendrikseipp
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please address my nitpicks and fix the code format with "cd misc; tox -e fix-format".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The abstraction skip on abstractions with zero weights at line 115 in cost_saturation/pho_heuristic.cc can throw away dead end information, since these abstractions can still contain states with infinite abstract goal distances.
This fix makes sure that only abstractions that contain no infinite abstract goal distances are thrown away.