Require Jenkins 2.479.3 or newer and Jakarta EE 9#508
Open
strangelookingnerd wants to merge 5 commits intojenkinsci:masterfrom
Open
Require Jenkins 2.479.3 or newer and Jakarta EE 9#508strangelookingnerd wants to merge 5 commits intojenkinsci:masterfrom
strangelookingnerd wants to merge 5 commits intojenkinsci:masterfrom
Conversation
mawinter69
suggested changes
May 18, 2025
mawinter69
reviewed
May 19, 2025
Co-authored-by: Markus Winter <m.winter@sap.com>
mawinter69
suggested changes
Jun 13, 2025
mawinter69
left a comment
There was a problem hiding this comment.
Looks good from pom point of view. The hpi is 2.4MiB and no longer over 12 MiB
Can't judge the other changes
Contributor
Author
|
@jenkinsci/datadog-plugin-developers Kindly requesting a review. |
Collaborator
|
Hey @strangelookingnerd, thanks for the contribution, but for now, we still want to be compatible with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require Jenkins 2.479.3 or newer and Jakarta EE 9
Jenkins 2.479.3 provides Jakarta EE 9, Eclipse Jetty 12, Spring Security 6, and Java 17.
Testing done
mvn clean verify- I had local test failures that I also had without my changes. So not entirely sure if these changes broke something or not. I'd advice that these changes are validated before merging.Submitter checklist