Skip to content

Conversation

@froque
Copy link
Member

@froque froque commented Jan 10, 2026

Ban JUnit 4 imports

To prevent regressions when adding new tests, jenkinsci/plugin-pom#1178 introduced a new flag that enables a Maven Enforcer rule banning org.junit.* imports while allowing org.junit.jupiter.*.

With this change, the build will fail if any org.junit.* imports are introduced.

Testing done

None. Rely on ci.jenkins.io.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

To prevent regressions when adding new tests, jenkinsci/plugin-pom#1178
introduced a new flag that enables a Maven Enforcer rule banning
org.junit.* imports while allowing org.junit.jupiter.*.

With this change, the build will fail if any org.junit.* imports are
introduced.
@froque froque requested a review from a team as a code owner January 10, 2026 01:37
@strangelookingnerd strangelookingnerd mentioned this pull request Jan 10, 2026
6 tasks
@froque froque merged commit dca0728 into master Jan 10, 2026
17 checks passed
@froque froque deleted the ban_junit4 branch January 11, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant