Open
Conversation
MarkEWaite
suggested changes
May 3, 2022
| > `org.jenkinsci.plugins.durabletask.BourneShellScript.FORCE_SHELL_WRAPPER=true` to the Java command line used to start Jenkins. | ||
|
|
||
| - Update ssh-slaves ([PR \#100](https://github.com/jenkinsci/durable-task-plugin/pull/100)) | ||
| - Update ssh-agents ([PR \#100](https://github.com/jenkinsci/durable-task-plugin/pull/100)) |
Contributor
There was a problem hiding this comment.
Slightly different for linguistic reasons. The previous entry used the "plugin ID" which is not well known to users and is unchanging even for inclusive naming. Let's use the plugin name rather than the identifier
Suggested change
| - Update ssh-agents ([PR \#100](https://github.com/jenkinsci/durable-task-plugin/pull/100)) | |
| - Update SSH Build Agents plugin ([PR \#100](https://github.com/jenkinsci/durable-task-plugin/pull/100)) |
| process namespaces). | ||
| - Bugfix: Use `sh` to run shell scripts rather than attempting to | ||
| use the absolute path to the default shell from the master on | ||
| use the absolute path to the default shell from the Controller on |
Contributor
There was a problem hiding this comment.
Lower case rather than upper case inside the sentence
Suggested change
| use the absolute path to the default shell from the Controller on | |
| use the absolute path to the default shell from the controller on |
|
|
||
| - Do not kill a one-shot agent merely because a flyweight task | ||
| happened to run on it (rather than on master as usual). Works around | ||
| happened to run on it (rather than on the Controller as usual). Works around |
Contributor
There was a problem hiding this comment.
Lower case
Suggested change
| happened to run on it (rather than on the Controller as usual). Works around | |
| happened to run on it (rather than on the controller as usual). Works around |
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>ssh-slaves</artifactId> | ||
| <artifactId>ssh-agents</artifactId> |
Contributor
There was a problem hiding this comment.
That's an identifier, needs to remain the same
Suggested change
| <artifactId>ssh-agents</artifactId> | |
| <artifactId>ssh-slaves</artifactId> |
| /*package*/ static final class ShellController extends FileMonitoringController { | ||
|
|
||
| /** Last time we checked the timestamp, in nanoseconds on the master. */ | ||
| /** Last time we checked the timestamp, in nanoseconds on the Controller. */ |
Contributor
There was a problem hiding this comment.
Lower case
Suggested change
| /** Last time we checked the timestamp, in nanoseconds on the Controller. */ | |
| /** Last time we checked the timestamp, in nanoseconds on the controller. */ |
| } | ||
| } catch (Exception x) { | ||
| // note that LOGGER here is going to the agent log, not master log | ||
| // note that LOGGER here is going to the agent log, not the Controller log |
Contributor
There was a problem hiding this comment.
Lower case
Suggested change
| // note that LOGGER here is going to the agent log, not the Controller log | |
| // note that LOGGER here is going to the agent log, not the controller log |
car-roll
reviewed
May 4, 2022
| /** | ||
| * A remote handler which may be sent to an agent and handle process output and results. | ||
| * If it needs to communicate with the master, you may use {@link VirtualChannel#export}. | ||
| * If it needs to communicate with the Controller, you may use {@link VirtualChannel#export}. |
There was a problem hiding this comment.
Suggested change
| * If it needs to communicate with the Controller, you may use {@link VirtualChannel#export}. | |
| * If it needs to communicate with the controller, you may use {@link VirtualChannel#export}. |
I assume the same here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inclusive naming changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue