Closed
Conversation
abayer
approved these changes
Feb 19, 2018
svanoort
requested changes
Feb 19, 2018
Member
svanoort
left a comment
svanoort
left a comment
There was a problem hiding this comment.
Blocking until can do a deep review/test.
Member
oleg-nenashev
previously requested changes
Apr 2, 2018
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Requesting changes to reflect the current status of #60
…ableTaskStep.Execution.stop delete the control dir and having the watcher task handle that.
Member
Author
|
Please do not perform line-by-line reviews in this PR. Rather, review component PRs. |
jglick
commented
Jul 25, 2018
| try (FileChannel ch = FileChannel.open(Paths.get(logFile.getRemote()), StandardOpenOption.READ)) { | ||
| InputStream locallyEncodedStream = Channels.newInputStream(ch.position(lastLocation)); | ||
| InputStream utf8EncodedStream = cs == null ? locallyEncodedStream : new ReaderInputStream(new InputStreamReader(locallyEncodedStream, cs), StandardCharsets.UTF_8); | ||
| CountingInputStream cis = new CountingInputStream(utf8EncodedStream); |
Member
Author
There was a problem hiding this comment.
This probably does the same miscount when transcoding as #61, to be confirmed.
Member
Author
|
Closing as this is now identical to #60. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates #60 & #61. Please leave line comments in one of the parents until you are referring specifically to something about the integration.
@reviewbybees