Shut down watchService when Jenkins shuts down#86
Merged
dwnusbaum merged 1 commit intojenkinsci:masterfrom Nov 1, 2018
Merged
Conversation
dwnusbaum
approved these changes
Oct 29, 2018
jglick
added a commit
to jglick/ant-plugin
that referenced
this pull request
Oct 29, 2018
svanoort
approved these changes
Oct 30, 2018
Member
svanoort
left a comment
svanoort
left a comment
There was a problem hiding this comment.
Yup, this is the safe way to do this. 👍
jglick
added a commit
to jglick/durable-task-plugin
that referenced
this pull request
Apr 12, 2019
Removes the code added in jenkinsci#86 which is not needed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#84 is preferable but this should be easier to get merged quickly so I am starting here.