Skip to content

Correct test failure in non-english system#125

Open
Wadeck wants to merge 2 commits intojenkinsci:masterfrom
Wadeck:MAKE_TEST_PASS_ON_NON_ENG_SYSTEM
Open

Correct test failure in non-english system#125
Wadeck wants to merge 2 commits intojenkinsci:masterfrom
Wadeck:MAKE_TEST_PASS_ON_NON_ENG_SYSTEM

Conversation

@Wadeck
Copy link

@Wadeck Wadeck commented Jul 16, 2018

  • due to the i18n, the expected text was not dynamic. Now it uses the same i18n method to be accurate

@cloudbees/team-foundation

Copy link

@varyvol varyvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doubt but looks good.

import static org.mockito.BDDMockito.*;

import hudson.Messages;
import hudson.Util;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this import necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants