Skip to content

[JENKINS-74095] [JENKINS-74096] [JENKINS-74097] [JENKINS-74099] Remove legacy checkUrl handlers #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 5 commits into from
Nov 25, 2024
Merged

[JENKINS-74095] [JENKINS-74096] [JENKINS-74097] [JENKINS-74099] Remove legacy checkUrl handlers #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e7cc96
remove legacy inline onClick handler in AbstractPlotPublisher/config.…
shlomomdahan Nov 19, 2024
32543ea
remove legacy inline onClick handlers
shlomomdahan Nov 19, 2024
8817337
use checkDepends on for Pipeline compatibility
shlomomdahan Nov 21, 2024
22b0d47
use checkDepends on for Pipeline compatibility
shlomomdahan Nov 21, 2024
8cf63a3
Merge branch 'master' into JENKINS-74095-74096-74097-74099
MarkEWaite Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,8 @@
<f:entry title="" description="${%A new data series definition}">
<f:repeatable var="series" items="${plot.series}" minimum="1">
<div>
<f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
<f:textbox name="file" value="${series.file}"
checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)" />
<f:entry title="${%Data series file}" field="seriesFile" help="/plugin/plot/help-series.html">
<f:textbox name="file" value="${series.file}"/>
</f:entry>

<f:radioBlock name="fileType" value="properties" title="${%Load data from properties file}" help="/plugin/plot/help-properties.html" checked="${series.fileType=='properties' or series.fileType==null}">
Expand Down
3 changes: 2 additions & 1 deletion src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
<div>
<f:entry title="${%Data series file}" field="file" help="/plugin/plot/help-series.html">
<f:textbox name="file" value="${series.file}"
checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)"/>
checkUrl="descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile"
checkDependsOn="" />
</f:entry>
<f:nested>
<div>
Expand Down
3 changes: 2 additions & 1 deletion src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
<div>
<f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
<f:textbox name="file" value="${series.file}"
checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)" />
checkUrl="descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile"
checkDependsOn="" />
</f:entry>
<f:nested>
<f:entry title="${%Data series legend label}" help="/plugin/plot/help-legend.html">
Expand Down
3 changes: 2 additions & 1 deletion src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
<div>
<f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
<f:textbox name="file" value="${series.file}"
checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)" />
checkUrl="descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile"
checkDependsOn="" />
</f:entry>
<f:nested>
<div>
Expand Down