Replace outdated icons with analytics symbol #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://weekly.ci.jenkins.io/design-library/symbols/ shows the preferred images for Jenkins icons. The symbols scale better and look more consistent with the rest of Jenkins. I chose "analytics" from the available symbols listed at https://github.com/jenkinsci/jenkins/tree/master/war/src/main/resources/images/symbols I added the page-headline class to the h1 headings because that seems to be a class that is used in other page headlines. Testing done: * Confirmed that images were displayed as expected in freestyle projects and in matrix projects
jonesbusy
approved these changes
Jan 5, 2025
Contributor
|
Thanks! |
gounthar
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace outdated icons with analytics symbol
The design library shows the preferred images for Jenkins icons. The symbols scale better and look more consistent with the rest of Jenkins.
No tests added because this a a look and feel change. Not well suited to automated tests.
What has been done
Screenshots
How to test
Checklist
.github/release-drafter.yml)