-
-
Notifications
You must be signed in to change notification settings - Fork 93
Add support for configurable plot width/height #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configurable plot width/height #71
Conversation
|
I have exactly the same issue. width, height argument does not affect the plot (it should according to documentation). |
|
I would love to see this in the next version. For now, the only way to enlarge the plot is modify the querystring |
Also removes the outdated copyright message. The file content is original so it should not use a copyright date that is over 10 years before the text was created. Git history shows the creation date of the file.
|
@markus-franke sorry for the long delay reviewing the pull request. I tested the pull request with Jenkins 2.462.3 and was unable to have it actually apply the values for width and height. I created a freestyle project, defined the plot height and width, and ran the job several times. The plot width and height were unchanged on the display. The plot width and height were not retained in the freestyle job definition form. When I configured the job again, the width and height fields were empty. |
MarkEWaite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs more work to assure that the plot width and height configuration is saved when the form is saved and that the plot width and plot height are used when generating the plot.
|
@MarkEWaite Thanks for getting back to this ;-) Honestly after 3 years I don't know how to continue working on this. It's long time ago that I was working with Jenkins and I don't even quite remember how to get the plugin up and running again. Feel free to close the MR. Otherwise maybe somebody else wants to continue working on it. |
Thanks so much @markus-franke . Closing the pull request. Others can reopen it if they want to take it further. |
Jira: JENKINS-59237
What has been done
How to test
Checklist
.github/release-drafter.yml) -> I don't seem to have permissions to add labels to this PR.