[JENKINS-48466] Provide JUnit 5 support for JenkinsRule#560
Merged
basil merged 2 commits intojenkinsci:masterfrom Jul 18, 2022
Merged
[JENKINS-48466] Provide JUnit 5 support for JenkinsRule#560basil merged 2 commits intojenkinsci:masterfrom
JenkinsRule#560basil merged 2 commits intojenkinsci:masterfrom
Conversation
timja
approved these changes
Jul 18, 2022
jetersen
reviewed
Aug 8, 2022
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>4.13.2</version> |
Member
There was a problem hiding this comment.
Any particular reason this was removed from dependency management?
junit-bom does not include a junit version
Member
|
For the record, parameterized test selection no longer seems to work in plugins (discovered in jenkinsci/workflow-durable-task-step-plugin#323); based on comments in SUREFIRE-2010 I suspect the use of the Jupiter engine (even for JUnit 4 tests) is the cause, and unfortunately apache/maven-surefire#476 is stalled. |
jglick
added a commit
to jglick/durable-task-plugin
that referenced
this pull request
Aug 18, 2023
…un e.g. `mvn test -Dtest="BourneShellScriptTest#binaryCaching[0: ON_CONTROLLER]"`
Member
|
Workaround, based on this tip, presuming that the plugin does not in fact contain any Jupiter-based tests: <build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit47</artifactId>
<version>${maven-surefire-plugin.version}</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</pluginManagement>
</build> |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See jenkinsci/jenkins-test-harness#438 for the PR description.