Skip to content

[JENKINS-34637] Test for timeout bug#24

Merged
jglick merged 10 commits intojenkinsci:masterfrom
jglick:timeout-block-JENKINS-34637
Oct 24, 2016
Merged

[JENKINS-34637] Test for timeout bug#24
jglick merged 10 commits intojenkinsci:masterfrom
jglick:timeout-block-JENKINS-34637

Conversation

@jglick
Copy link
Member

@jglick jglick commented Oct 18, 2016

JENKINS-34637

Downstream of jenkinsci/workflow-cps-plugin#76, the actual fix. Incorporates #22 (thanks!).

@reviewbybees

}

private void cancel() {
listener.getLogger().println("Cancelling nested steps due to timeout");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only effective after jenkinsci/workflow-support-plugin#19.

@ghost
Copy link

ghost commented Oct 18, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is like a breath of fresh air!

@svanoort
Copy link
Member

🐝 LGTM

@jglick jglick merged commit 5d2b232 into jenkinsci:master Oct 24, 2016
@jglick jglick deleted the timeout-block-JENKINS-34637 branch October 24, 2016 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants