Send any output from Run.getEnvironment(TaskListener) to the overall build, not step, log#75
Merged
jglick merged 1 commit intojenkinsci:masterfrom Oct 4, 2018
Conversation
…e is expected, send it to the overall build log not the step log. This allows us to call context.get(EnvVars.class) even on a FlowNode which has not yet been attached to the graph. (cherry picked from commit d5d1f46)
This was referenced Oct 4, 2018
svanoort
approved these changes
Oct 4, 2018
Member
svanoort
left a comment
svanoort
left a comment
There was a problem hiding this comment.
Seems sane to me -- no reason why this should need to log specifically for the step.
dwnusbaum
approved these changes
Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #15 as it is an independently releasable fix needed by a fix in
workflow-cps.