Specs on GitHub actions, BigDecimal dep. for Ruby 3.5, Redis gem update, require Ruby 3.1#9
Draft
swiknaba wants to merge 12 commits intojeopard:masterfrom
Draft
Specs on GitHub actions, BigDecimal dep. for Ruby 3.5, Redis gem update, require Ruby 3.1#9swiknaba wants to merge 12 commits intojeopard:masterfrom
swiknaba wants to merge 12 commits intojeopard:masterfrom
Conversation
Fix deprecation for redis pipelines syntax
Improve performance by fixing getting rates from memory
* drop travis * Update CONTRIBUTING.md * add testing on Github actions * Bump Ruby 2 -> 3, update Redis 3 -> 4+ * fix syntax required for Ruby 3 * update syntax for RSpec * Ruby 2 Array =~ operator is confusing and works differently in Ruby 3. Refactor * no need to spin up different redis locally * add BigDecimal and don't rely on .to_d * iso_currency_code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Thanks for taking over the repo from Skyscanner/historical-bank-ruby#4
Links to PRs are likely broken when we moved the fork, here our old fork with PRs: https://github.com/lh-innovationhub/historical-bank-ruby-old
TL;DR:
BigDecimalto prepare for Ruby 3.5Note: The redis gem version is super relaxed atm; we've tested this with v4 and v5. Ideally, we'd use, e.g., appraisal to run tests against both versions (or you pin this down to only one major version). -- just didn't have time for that yet.
Travis vs. GitHub actions: no preferences here, there was some hiccups with Travis a while ago so we just switched got GH actions. I see it works on your master branch, feel free to revert to Travis.
We assumed the project was dead for good so we weren't squeamish 😄
Let me know what you think; happy to improve :-)