Open
Conversation
Owner
|
Will take a look this weekend. Thanks. |
Owner
|
Revisiting this (long weekend! :). Still relevant? Do you have failing test cases you can supply, just to make things concrete? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't necessarily ready to be merged, but I wanted to open a discussion around the handling of explicitly typed maps and slices. At the present moment,
flattenwill only truly flatten a string (which would be unmarshalled to amap[string]interface{}) or a variable which has been declared as amap[string]interface{}or[]interface{}, which means that users who pass in an explicitly typed variable (e.g.map[string]stringor[]string) won't receive a completely flattened object.e.g. see #5
The changes in this PR at the moment fix the problem for slices of strings (
[]string) however there's a number of other explicit types that should theoretically be supported - booleans, numbers of various types, etc.We could either explicitly support each of these, or simply try to catch them and copy to a
[]interface{}.