Adds a public API for creating Object IDs#152
Open
atheriel wants to merge 1 commit intojeroen:masterfrom
Open
Conversation
atheriel
force-pushed
the
oid-creation
branch
from
a686c0a to
01c9187
Compare
atheriel
force-pushed
the
oid-creation
branch
from
01c9187 to
8794fc7
Compare
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 37.43% 37.54% +0.11%
==========================================
Files 130 130
Lines 21904 21924 +20
==========================================
+ Hits 8199 8232 +33
+ Misses 13705 13692 -13
Continue to review full report at Codecov.
|
|
What else is needed to merge this PR? I need this feature and can contribute to get this merged. |
jeroen
force-pushed
the
master
branch
2 times, most recently
from
032d2f1 to
8bdd0e3
Compare
jeroen
force-pushed
the
master
branch
3 times, most recently
from
12d33b7 to
02d0e8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #151 and some previous issues, this allows users to create OIDs that will be honored by mongo. I've also included an example and appropriate unit tests.