Correctly pass on maxiter argument to inner minimizer when basinhopping#43
Merged
jessegrabowski merged 1 commit intomainfrom Aug 4, 2025
Merged
Correctly pass on maxiter argument to inner minimizer when basinhopping#43jessegrabowski merged 1 commit intomainfrom
jessegrabowski merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the basinhopping optimization function where the maxiter argument was being removed from minimizer_kwargs by the determine_maxiter function but not properly restored, preventing the maximum iteration limit from being passed to the inner minimizer.
- Restores the
maxiterparameter tominimizer_kwargsafter it's extracted bydetermine_maxiter - Adds explanatory comment about why the parameter needs to be restored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.