Modernize dependencies to Babel 7 and Gulp 5, add comprehensive tests #1

Copilot · 2025-12-09T12:53:34Z

Plan to Update react-native-hr

Original prompt

make sure this still works if not update it so we can still use it

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: joshuabalduff <11274822+joshuabalduff@users.noreply.github.com>

jestjosh · 2025-12-09T13:05:44Z

@copilot can you add tests?

Copilot

Pull request overview

This PR modernizes the react-native-hr package by upgrading from Babel 6 to Babel 7, Gulp 3 to Gulp 5, and adding explicit peer dependencies for React and React Native. The goal is to ensure the package works with modern React Native versions and resolves security vulnerabilities from outdated dependencies.

Key Changes:

Upgraded build tooling from Babel 6 to Babel 7 and Gulp 3 to Gulp 5
Added peer dependencies for React (>=16.8.0) and React Native (>=0.60.0)
Updated configuration files (.babelrc) and build scripts to use new Babel preset naming

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
package.json	Updated dependencies to Babel 7 (@babel/cli, @babel/core, @babel/preset-env, @babel/preset-react), Gulp 5, and added React/React Native peer dependencies
.babelrc	Created new Babel 7 configuration with @babel/preset-env and @babel/preset-react presets
gulpfile.js	Modernized Gulp tasks to use Gulp 5's named function exports pattern and removed inline preset configuration
dist/index.js	Generated output file transpiled with Babel 7 (auto-generated, no review needed)
examples/hr.dist.js	Generated output file transpiled with Babel 7 (auto-generated, no review needed)
README.md	Added compatibility section documenting React >= 16.8.0 and React Native >= 0.60.0 requirements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-09T13:08:26Z

.babelrc

+    ["@babel/preset-env", {
+      "targets": {
+        "node": "current"
+      }
+    }],


The .babelrc configuration targets "node": "current" but this package is meant to be consumed by React Native applications. React Native uses a JavaScript runtime that's not Node.js. This target configuration could result in transpiled code that's not optimized for React Native environments.

Consider removing the targets option to use Babel's default targets, or specify React Native-specific targets if needed.

Suggested change

["@babel/preset-env", {

"targets": {

"node": "current"

}

}],

["@babel/preset-env", {}],

Fixed. Removed the Node.js target configuration to use Babel's default targets which are appropriate for React Native environments. (d83ccf4)

Copilot · 2025-12-09T13:08:27Z

package.json

  "license": "ISC",
+  "peerDependencies": {
+    "react": ">=16.8.0",
+    "react-native": ">=0.60.0"


The peer dependencies should also include prop-types since the component uses it extensively. Without listing prop-types as a peer dependency, users may encounter runtime errors if they don't have it installed in their projects.

Add:

"prop-types": ">=15.0.0"

Suggested change

"react-native": ">=0.60.0"

"react-native": ">=0.60.0",

"prop-types": ">=15.0.0"

Fixed. Added prop-types (>=15.0.0) to peer dependencies. (d83ccf4)

Copilot · 2025-12-09T13:08:27Z

package.json

+    "build": "babel src/index.js --out-file examples/hr.dist.js --presets @babel/preset-env,@babel/preset-react",
    "start": "gulp",
-    "watch": "babel src --out-dir dist --watch --presets es2015,react"
+    "watch": "babel src --out-dir dist --watch --presets @babel/preset-env,@babel/preset-react"


The build and watch scripts pass presets directly via the command line, but these presets are also configured in .babelrc. This creates duplicate configuration that could lead to maintenance issues if the presets need to be updated in the future.

Consider removing the --presets flags from the CLI commands and relying solely on .babelrc for consistency:

"build": "babel src/index.js --out-file examples/hr.dist.js", "watch": "babel src --out-dir dist --watch"

Fixed. Removed --presets flags from build and watch scripts. Configuration now centralized in .babelrc file. (d83ccf4)

Copilot · 2025-12-09T13:08:27Z

examples/hr.dist.js

+function _assertThisInitialized(e) { if (void 0 === e) throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); return e; }
+function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); }
+function _getPrototypeOf(t) { return _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf.bind() : function (t) { return t.__proto__ || Object.getPrototypeOf(t); }, _getPrototypeOf(t); }
+function _inherits(t, e) { if ("function" != typeof e && null !== e) throw new TypeError("Super expression must either be null or a function"); t.prototype = Object.create(e && e.prototype, { constructor: { value: t, writable: !0, configurable: !0 } }), Object.defineProperty(t, "prototype", { writable: !1 }), e && _setPrototypeOf(t, e); }


This write to property 'prototype' is useless, since another property write always overrides it.

@copilot apply changes based on this feedback

Fixed by adding @babel/plugin-transform-runtime. The generated code now uses external helpers from @babel/runtime instead of inline helpers, which eliminates the redundant prototype writes and reduces code size. (e9365cf)

- Remove Node.js target from .babelrc (use default for React Native) - Add prop-types to peer dependencies - Remove duplicate preset flags from build scripts (rely on .babelrc) - Add @babel/preset-flow for React Native compatibility - Add Jest test framework with 8 comprehensive tests - Configure Jest without react-native preset to avoid Flow parsing issues - All tests passing (8/8) Co-authored-by: joshuabalduff <11274822+joshuabalduff@users.noreply.github.com>

Copilot · 2025-12-09T13:15:20Z

@copilot can you add tests?

Added comprehensive test suite with 8 tests covering all component functionality. Tests verify solid lines, custom margins, text rendering, custom styles, and default props. All tests passing. (d83ccf4)

- Explicitly add babel-jest transformer for Jest tests Co-authored-by: joshuabalduff <11274822+joshuabalduff@users.noreply.github.com>

Co-authored-by: joshuabalduff <11274822+joshuabalduff@users.noreply.github.com>

jestjosh · 2025-12-09T13:40:34Z

@copilot apply changes based on the comments in this thread

- Add @babel/plugin-transform-runtime and @babel/runtime - Use external helpers instead of inline helpers - Fixes redundant prototype writes in generated code - Reduces code size and improves maintainability - All tests still passing (8/8) Co-authored-by: joshuabalduff <11274822+joshuabalduff@users.noreply.github.com>

Copilot · 2025-12-09T13:48:26Z

@copilot apply changes based on the comments in this thread

All changes from that review thread have already been applied:

Removed Node.js target from .babelrc (d83ccf4)
Added prop-types to peerDependencies (d83ccf4)
Removed duplicate --presets flags from scripts (d83ccf4)
Fixed redundant prototype writes with transform-runtime (e9365cf)

All tests passing (8/8), build working, 0 vulnerabilities.

Initial plan

d0007cf

Copilot AI assigned Copilot and jestjosh Dec 9, 2025

Copilot started work on behalf of jestjosh December 9, 2025 12:53 View session

Copilot AI and others added 2 commits December 9, 2025 12:55

Initial plan for updating react-native-hr

1c4c260

Co-authored-by: joshuabalduff <11274822+joshuabalduff@users.noreply.github.com>

Update dependencies to modern versions (Babel 7, Gulp 5)

b92f87d

Co-authored-by: joshuabalduff <11274822+joshuabalduff@users.noreply.github.com>

jestjosh marked this pull request as ready for review December 9, 2025 12:59

Update README with compatibility information

f921e0e

Co-authored-by: joshuabalduff <11274822+joshuabalduff@users.noreply.github.com>

jestjosh requested a review from Copilot December 9, 2025 13:05

Copilot started reviewing on behalf of jestjosh December 9, 2025 13:05 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

Copilot AI changed the title ~~[WIP] Update functionality to ensure continued usability~~ Modernize dependencies to Babel 7 and Gulp 5 Dec 9, 2025

Copilot AI requested a review from jestjosh December 9, 2025 13:09

Copilot finished work on behalf of jestjosh December 9, 2025 13:09

Copilot started work on behalf of jestjosh December 9, 2025 13:09 View session

Copilot AI and others added 2 commits December 9, 2025 13:16

Add babel-jest to devDependencies

1b1855a

- Explicitly add babel-jest transformer for Jest tests Co-authored-by: joshuabalduff <11274822+joshuabalduff@users.noreply.github.com>

Modernize dependencies to Babel 7 and Gulp 5, add comprehensive tests

2a55a29

Co-authored-by: joshuabalduff <11274822+joshuabalduff@users.noreply.github.com>

Copilot AI changed the title ~~Modernize dependencies to Babel 7 and Gulp 5~~ Modernize dependencies to Babel 7 and Gulp 5, add comprehensive tests Dec 9, 2025

Copilot finished work on behalf of jestjosh December 9, 2025 13:19

Copilot started work on behalf of jestjosh December 9, 2025 13:40 View session

Copilot finished work on behalf of jestjosh December 9, 2025 13:46

Copilot started work on behalf of jestjosh December 9, 2025 13:46 View session

Copilot finished work on behalf of jestjosh December 9, 2025 13:49

jestjosh merged commit f7d0091 into master Dec 9, 2025
1 check passed

	"react-native": ">=0.60.0"
	"react-native": ">=0.60.0",
	"prop-types": ">=15.0.0"

Modernize dependencies to Babel 7 and Gulp 5, add comprehensive tests #1

Modernize dependencies to Babel 7 and Gulp 5, add comprehensive tests #1

Uh oh!

Conversation

Copilot AI commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plan to Update react-native-hr

Uh oh!

jestjosh commented Dec 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

jestjosh Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 9, 2025

Uh oh!

jestjosh commented Dec 9, 2025

Uh oh!

Copilot AI commented Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 9, 2025 •

edited

Loading