Increase logging activity retention periods #1500
Open
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR extends the retention periods for authentication and email activity logs by splitting the original single retention period into two separate constants with different values.
- Renamed
DELETE_ACTIVITY_DAYStoDELETE_AUTH_ACTIVITY_DAYSwith a value of 365 days (previously 30 days) - Added
DELETE_EMAIL_ACTIVITY_DAYSconstant with a value of 180 days - Updated the
pruneExpiredRecordsfunction to use the new constants appropriately for login and email activity cleanup
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libs/auth/server/src/lib/auth.constants.ts | Replaced single DELETE_ACTIVITY_DAYS constant with two separate constants: DELETE_AUTH_ACTIVITY_DAYS (365 days) and DELETE_EMAIL_ACTIVITY_DAYS (180 days) |
| libs/auth/server/src/lib/auth.db.service.ts | Updated imports and the pruneExpiredRecords function to use the new separate retention constants for login and email activities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the retention period for login and email activity logs to 365 days and 180 days, respectively, to improve logging activity management.