Added search highlight in response tab.#71
Open
Hafiz-Waleed-Hussain wants to merge 4 commits intojgilfelt:masterfrom
Open
Added search highlight in response tab.#71Hafiz-Waleed-Hussain wants to merge 4 commits intojgilfelt:masterfrom
Hafiz-Waleed-Hussain wants to merge 4 commits intojgilfelt:masterfrom
Conversation
olivierperez
suggested changes
Sep 19, 2018
olivierperez
left a comment
olivierperez
left a comment
There was a problem hiding this comment.
Some changes could be done, but this feature can really add to the lib.
library/src/main/java/com/readystatesoftware/chuck/internal/support/SearchHighlightUtil.java
Outdated
Show resolved
Hide resolved
| public boolean onQueryTextChange(String newText) { | ||
| String text = body.getText().toString(); | ||
| if (newText.trim().length() > 0 && text.contains(newText.trim())) | ||
| body.setText(SearchHighlightUtil.format(body.getText().toString(), newText)); |
There was a problem hiding this comment.
You should originalBody here, no ?
body.setText(SearchHighlightUtil.format(originalBody, newText));
| TextView headers; | ||
| TextView body; | ||
|
|
||
|
|
|
|
||
| private int type; | ||
| private HttpTransaction transaction; | ||
| private String originalBody; |
There was a problem hiding this comment.
You can maybe delete this field, and use transaction.getFormattedRequestBody() instead. No need to add a field if another field already holds the value.
| * Created by waleed on 17/02/2018. | ||
| */ | ||
|
|
||
| public class SearchHighlightUtil { |
There was a problem hiding this comment.
This is not a valid Javadoc. Take advantage of this fix for adding description to this new class.
Author
|
Thank you for the detailed code review. I will do fixes and update the request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added a search functionality in the response tab. Now anyone can see highlighted search criteria on response tab.