Open
Conversation
- adding a Messages history page into the user menu - adding message history into the trade deals, to remind user of exchanges with traders
Owner
|
personally, I liked the changes. I'm not sure only about the UI for the message history. it's not clean to me that if it was a received message or sent message. once we can't "continue" conversations on the website (it's just the one time message) we should keep it simpler. when showing the history on the trade page, it's a bit confusing. maybe something simpler: what do you think? |
Contributor
Author
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does :
Adding a global message history page into the user menu
Adding message history into the trade deals, to remind user of exchanges with traders (Fixing #30 )
You can try it here : http://elephpant-messages.wilkins.fr/
With log in john@example.com / secret