Added large size elephpants#58
Added large size elephpants#58wimg wants to merge 18 commits intojgrossi:masterfrom wimg:wimg-patch-1
Conversation
Merge down
Added large size
Added large size
Added large size
Added large size
Added large size
Added large size
Added large size
Added large size
|
Will squash first ;-) |
|
Might be better to show the size when it is not "normal" and give all existing elephpants a size of "normal" or "small". Implementation would be a bit cleaner. |
|
Will you recreate a PR @wimg? |
|
I will, but currently reinstalling my dev system after a hardware problem. Give me a few days. |
|
@doppynl Re-reading your comment... isn't what you're saying contradictory ? Or am I misreading ? |
|
I think my comment wasn't very clear. I'll try to rephrase it. The implementation in the pull request checks the size and if it is "large" it will display the size. In other cases it will not show the size. To me the implementation would be more clean if:
This would also make it easier to make additions in the future. Like new sizes, or filtering based on size. |
|
Made a new pull request #86 to handle this. |
I added the large (jumbo) size elephpants. They are in the db in a field "size" (free text, who knows what we get in the future).
Fixes #7