-
Notifications
You must be signed in to change notification settings - Fork 3
[석태진] 숫자야구 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mintjordy
wants to merge
24
commits into
jhta1805:taejinseok
Choose a base branch
from
mintjordy:baseball-step1
base: taejinseok
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[석태진] 숫자야구 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mintjordy
commented
Jul 17, 2020
Comment on lines
+44
to
+48
| void create_exception_when_balls_size_is_invalid() { | ||
| NumberBall firstNumber = NumberBall.of(1); | ||
| NumberBall secondNumber = NumberBall.of(2); | ||
| assertThatThrownBy(() -> new NumberBalls(list(firstNumber, secondNumber))) | ||
| .isInstanceOf(IllegalArgumentException.class); |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
예외 클래스를 확인할때는 의도한 예외가 생성되었는지 정확히 확인하기 위해 예외 메시지를 확인하는 과정도 포함시킨다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.