Skip to content

Fix strict mode syntax error#194

Open
partap wants to merge 1 commit intojindw:masterfrom
partap:master
Open

Fix strict mode syntax error#194
partap wants to merge 1 commit intojindw:masterfrom
partap:master

Conversation

@partap
Copy link

@partap partap commented Jan 19, 2017

I ran across this error from an embedded STB version of Opera when including this library in a rollup bundle:

"Uncaught SyntaxError: In strict mode code, functions can only be declared at top level or immediately within another function."

It was preventing the entire bundle from being loaded... these changes satisfy the parser.

"Uncaught SyntaxError: In strict mode code, functions can only be declared at top level or immediately within another function."
@awerlang
Copy link

How can we get this merged in? It is failing on iOS (Safari / Chrome).

@awerlang
Copy link

Thinking about that, the tooling (rollup) shouldn't be adding a "use strict" on top of this module, because it isn't intended to be run on a strict environment. It should add only for your own ES6 modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants