Skip to content

DEPS: Bump the embroider group across 1 directory with 2 updates#1550

Open
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/embroider-73b1796819
Open

DEPS: Bump the embroider group across 1 directory with 2 updates#1550
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/embroider-73b1796819

Conversation

@dependabot
Copy link

@dependabot dependabot bot commented on behalf of github Jan 26, 2026

Bumps the embroider group with 2 updates in the / directory: @embroider/macros and @embroider/router.

Updates @embroider/macros from 1.19.4 to 1.19.6

Updates @embroider/router from 2.1.8 to 3.0.6

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 26, 2026
@greptile-apps
Copy link

greptile-apps bot commented Jan 26, 2026

Greptile Summary

Updates two Embroider packages: @embroider/macros from 1.16.12 to 1.19.6 (patch updates) and @embroider/router from 2.1.8 to 3.0.6 (major version bump). The PR description notes that @embroider/macros 1.19.6 includes a fix for dependency-aware macros in dummy apps, and @embroider/router includes a widened test-waiters range.

Key changes:

  • @embroider/macros receives bug fixes for dependency-aware macros in dummy apps
  • @embroider/router major version bump (2.x to 3.x) - requires verification that the breaking changes don't affect the mapping-router.js usage which extends EmbroiderRouter
  • Lockfile updated with 660+ lines of changes reflecting new versions and transitive dependencies

Confidence Score: 3/5

  • Safe to merge with testing - major version bump requires verification
  • Score reflects a standard Dependabot dependency update with one concern: @embroider/router has a major version bump from 2.x to 3.x which could contain breaking changes. While the code usage in mapping-router.js appears straightforward (extends EmbroiderRouter and overrides setupRouter), the major version change warrants runtime testing to ensure no breaking changes affect the custom router implementation. The @embroider/macros update is a minor patch with bug fixes.
  • frontend/discourse/package.json - verify @embroider/router major version compatibility

Important Files Changed

Filename Overview
frontend/discourse/package.json Updated @embroider/macros from 1.16.12 to 1.19.6 and @embroider/router from 2.1.8 to 3.0.6 (major version bump)
pnpm-lock.yaml Lockfile updated to reflect new Embroider package versions and their transitive dependencies

Sequence Diagram

sequenceDiagram
    participant Dependabot
    participant package.json
    participant pnpm-lock.yaml
    participant EmbroiderRouter
    participant MappingRouter
    
    Dependabot->>package.json: Update @embroider/macros<br/>1.16.12 → 1.19.6
    Dependabot->>package.json: Update @embroider/router<br/>2.1.8 → 3.0.6 (major)
    Dependabot->>pnpm-lock.yaml: Resolve dependencies<br/>(660+ line changes)
    
    Note over EmbroiderRouter,MappingRouter: Runtime Impact
    MappingRouter->>EmbroiderRouter: Extends base router
    MappingRouter->>EmbroiderRouter: Overrides setupRouter()
    EmbroiderRouter-->>MappingRouter: Provide routing functionality
    
    Note over package.json,pnpm-lock.yaml: Changes include:<br/>- Bug fix for dependency-aware macros<br/>- Wider test-waiters range<br/>- Potential breaking changes in v3.x
Loading

@github-actions
Copy link

PR body updated to plaintext for easier squash-merging. Original body content below:


Bumps the embroider group with 2 updates in the / directory: @embroider/macros and @embroider/router.

Updates @embroider/macros from 1.19.4 to 1.19.6

Release notes

Sourced from @​embroider/macros's releases.

v8.2.0-@​embroider/addon-dev

Release (2025-12-23)

  • @​embroider/addon-dev 8.2.0 (minor)
  • @​embroider/compat 4.1.12 (patch)
  • @​embroider/core 4.4.2 (patch)
  • @​embroider/macros 1.19.6 (patch)
  • @​embroider/shared-internals 3.0.2 (patch)
  • @​embroider/vite 1.5.0 (minor)

🚀 Enhancement

🐛 Bug Fix

  • @embroider/shared-internals

Committers: 2

v4.4.1-@​embroider/core

Release (2025-12-09)

  • @​embroider/core 4.4.1 (patch)

🐛 Bug Fix

Committers: 1

v2.1.12-@​embroider/router

Release (2025-12-02)

  • @​embroider/router 2.1.12 (patch)

🐛 Bug Fix

Committers: 1

v1.4.4-@​embroider/vite

Release (2025-12-04)

  • @​embroider/vite 1.4.4 (patch)

... (truncated)

Changelog

Sourced from @​embroider/macros's changelog.

Embroider Changelog

Release (2025-12-23)

  • @​embroider/addon-dev 8.2.0 (minor)
  • @​embroider/compat 4.1.12 (patch)
  • @​embroider/core 4.4.2 (patch)
  • @​embroider/macros 1.19.6 (patch)
  • @​embroider/shared-internals 3.0.2 (patch)
  • @​embroider/vite 1.5.0 (minor)

🚀 Enhancement

🐛 Bug Fix

  • @embroider/shared-internals

Committers: 2

Release (2025-12-09)

  • @​embroider/core 4.4.1 (patch)

🐛 Bug Fix

Committers: 1

Release (2025-12-04)

  • @​embroider/vite 1.4.4 (patch)

🐛 Bug Fix

  • @embroider/vite

🏠 Internal

Committers: 3

... (truncated)

Commits

Updates @embroider/router from 2.1.8 to 3.0.6

Release notes

Sourced from @​embroider/router's releases.

v8.2.0-@​embroider/addon-dev

Release (2025-12-23)

  • @​embroider/addon-dev 8.2.0 (minor)
  • @​embroider/compat 4.1.12 (patch)
  • @​embroider/core 4.4.2 (patch)
  • @​embroider/macros 1.19.6 (patch)
  • @​embroider/shared-internals 3.0.2 (patch)
  • @​embroider/vite 1.5.0 (minor)

🚀 Enhancement

🐛 Bug Fix

  • @embroider/shared-internals

Committers: 2

v4.4.1-@​embroider/core

Release (2025-12-09)

  • @​embroider/core 4.4.1 (patch)

🐛 Bug Fix

Committers: 1

v2.1.12-@​embroider/router

Release (2025-12-02)

  • @​embroider/router 2.1.12 (patch)

🐛 Bug Fix

Committers: 1

v1.4.4-@​embroider/vite

Release (2025-12-04)

  • @​embroider/vite 1.4.4 (patch)

... (truncated)

Changelog

Sourced from @​embroider/router's changelog.

Embroider Changelog

Release (2025-12-23)

  • @​embroider/addon-dev 8.2.0 (minor)
  • @​embroider/compat 4.1.12 (patch)
  • @​embroider/core 4.4.2 (patch)
  • @​embroider/macros 1.19.6 (patch)
  • @​embroider/shared-internals 3.0.2 (patch)
  • @​embroider/vite 1.5.0 (minor)

🚀 Enhancement

🐛 Bug Fix

  • @embroider/shared-internals

Committers: 2

Release (2025-12-09)

  • @​embroider/core 4.4.1 (patch)

🐛 Bug Fix

Committers: 1

Release (2025-12-04)

  • @​embroider/vite 1.4.4 (patch)

🐛 Bug Fix

  • @embroider/vite

🏠 Internal

Committers: 3

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/embroider-73b1796819 branch from cbf30d0 to 80556b7 Compare February 3, 2026 21:08
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/embroider-73b1796819 branch 2 times, most recently from 1355fef to 3d176fd Compare February 15, 2026 21:05
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/embroider-73b1796819 branch from 3d176fd to d4527ad Compare February 23, 2026 22:33
Bumps the embroider group with 2 updates in the / directory: [@embroider/macros](https://github.com/embroider-build/embroider/tree/HEAD/packages/macros) and [@embroider/router](https://github.com/embroider-build/embroider/tree/HEAD/packages/router).


Updates `@embroider/macros` from 1.19.4 to 1.19.6
- [Release notes](https://github.com/embroider-build/embroider/releases)
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md)
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/macros)

Updates `@embroider/router` from 2.1.8 to 3.0.6
- [Release notes](https://github.com/embroider-build/embroider/releases)
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md)
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/router)

---
updated-dependencies:
- dependency-name: "@embroider/macros"
  dependency-version: 1.19.6
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: embroider
- dependency-name: "@embroider/router"
  dependency-version: 3.0.6
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: embroider
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/embroider-73b1796819 branch from d4527ad to 2b4c0a9 Compare March 2, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants