This repository was archived by the owner on Nov 27, 2018. It is now read-only.
Add option to write configuration to log.#1
Open
LeakyBucket wants to merge 7 commits intojkassemi:masterfrom
LeakyBucket:config-logging
Open
Add option to write configuration to log.#1LeakyBucket wants to merge 7 commits intojkassemi:masterfrom LeakyBucket:config-logging
LeakyBucket wants to merge 7 commits intojkassemi:masterfrom
LeakyBucket:config-logging
Conversation
Owner
|
Thanks! Can you adjust for the new name (also thanks!), and add a rake task to dump the config? |
…iguration key and environment variable name
Probably the better way to use the system, since Rails.configuration is _generally_ for Rails-specific application settings.
Author
|
Still needs the rake task but the name change and a rebase are done. Would you prefer the rake task in a separate PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.