Testing PR - java.lsp.server #24

jlahoda · 2019-03-10T07:08:08Z

No description provided.

…to java-lsp-server

…s/incubator-netbeans into java-lsp-server

…ntation.

… API.

…avacapi.

jlahoda-jackpot · 2019-03-23T20:43:07Z

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/Server.java

+            List<FileObject> projectCandidates = new ArrayList<>();
+            List<WorkspaceFolder> folders = init.getWorkspaceFolders();
+            if (folders != null) {
+                for (WorkspaceFolder w : folders) {


Jackpot:
warning: Can use functional operations

jlahoda-jackpot · 2019-03-23T20:43:08Z

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/Server.java

+                }
+            }
+            List<Project> projects = new ArrayList<>();
+            for (FileObject candidate : projectCandidates) {


Jackpot:
warning: Can use functional operations

jlahoda-jackpot · 2019-03-23T20:43:09Z

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/Server.java

+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.MalformedURLException;
+import java.net.URL;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-03-23T20:43:10Z

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/Server.java

+import org.openide.filesystems.FileUtil;
+import org.openide.modules.ModuleInfo;
+import org.openide.modules.Places;
+import org.openide.util.Exceptions;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-03-23T20:43:10Z

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/Server.java

+import org.netbeans.api.project.ui.OpenProjects;
+import org.netbeans.modules.java.lsp.server.text.TextDocumentServiceImpl;
+import org.netbeans.modules.java.lsp.server.workspace.WorkspaceServiceImpl;
+import org.netbeans.modules.parsing.impl.indexing.DefaultCacheFolderProvider;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-03-23T20:43:11Z

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/Server.java

+import org.netbeans.modules.parsing.impl.indexing.DefaultCacheFolderProvider;
+import org.netbeans.modules.parsing.impl.indexing.implspi.CacheFolderProvider;
+import org.openide.filesystems.FileObject;
+import org.openide.filesystems.FileUtil;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-03-23T20:43:12Z

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/Server.java

+            //XXX: ensure project opened:
+            try {
+                Class.forName("org.netbeans.modules.project.ui.OpenProjectList", false, Lookup.getDefault().lookup(ClassLoader.class)).getDeclaredMethod("waitProjectsFullyOpen").invoke(null);
+            } catch (Exception ex) {


Jackpot:
warning: Can be replaced with multicatch or several catch clauses catching specific exceptions

jlahoda-jackpot · 2019-03-23T20:43:12Z

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/Server.java

+
+        while (true) {
+            try {
+                Thread.sleep(100000);


Jackpot:
warning: Thread.sleep called in loop

jlahoda-jackpot · 2019-03-23T20:43:16Z

...factoring.java/src/org/netbeans/modules/refactoring/java/plugins/MoveMembersTransformer.java

+                case RETURN: returnTags.add(tag); break;
+                case THROWS: throwsTags.add(tag); break;
+                case PARAM: paramTags.add(tag); break;
+                default: otherTags.add(tag);


Jackpot:
warning: Can use functional operations

jlahoda-jackpot · 2019-03-23T20:43:27Z

java/javadoc/src/org/netbeans/modules/javadoc/hints/Analyzer.java

-import com.sun.javadoc.Type;
 import com.sun.source.doctree.AttributeTree;
 import com.sun.source.doctree.AuthorTree;
 import com.sun.source.doctree.CommentTree;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-03-23T20:43:28Z

java/javadoc/src/org/netbeans/modules/javadoc/hints/Analyzer.java

 import com.sun.tools.doclint.HtmlTag;
+import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Collections;


Jackpot:
warning: Unused Import

…led.

…old license by itself)

…y calling the correct superclass method instead of the synthetic bridge.

The relevant stacktraces for the affected threads are saved below. As there is also a warning logged with a clear indication: WARNING [org.netbeans.modules.parsing.impl.TaskProcessor]: ParserManager.parse called in AWT event thread by: org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.getPropertyName(MicronautJavaHyperlinkProvider.java:151) Stacktraces: "AWT-EventQueue-0" #24 prio=6 os_prio=0 cpu=69156.33ms elapsed=76496.39s tid=0x00007feca4122b90 nid=0x106e2a waiting on condition [0x00007fec9756e000] java.lang.Thread.State: WAITING (parking) at jdk.internal.misc.Unsafe.park(java.base@17.0.3/Native Method) - parking to wait for <0x00000006d7905fd0> (a java.util.concurrent.locks.ReentrantLock$FairSync) at java.util.concurrent.locks.LockSupport.park(java.base@17.0.3/LockSupport.java:211) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(java.base@17.0.3/AbstractQueuedSynchronizer.java:715) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(java.base@17.0.3/AbstractQueuedSynchronizer.java:938) at java.util.concurrent.locks.ReentrantLock$Sync.lock(java.base@17.0.3/ReentrantLock.java:153) at java.util.concurrent.locks.ReentrantLock.lock(java.base@17.0.3/ReentrantLock.java:322) at org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:170) at org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:83) at org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:454) at org.netbeans.api.java.source.JavaSource.runUserActionTask(JavaSource.java:425) at org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.getPropertyName(MicronautJavaHyperlinkProvider.java:151) at org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.resolve(MicronautJavaHyperlinkProvider.java:122) at org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.getHyperlinkSpan(MicronautJavaHyperlinkProvider.java:85) "Editor Parsing Loop (14-c4f2d87113e1a2d2d4e21e8952e1f99612d5b3fd)" #28 daemon prio=1 os_prio=0 cpu=65769.71ms elapsed=76494.46s tid=0x00007feca4401250 nid=0x106e35 in Object.wait() [0x00007fec957fe000] java.lang.Thread.State: WAITING (on object monitor) at java.lang.Object.wait(java.base@17.0.3/Native Method) - waiting on <no object reference available> at java.lang.Object.wait(java.base@17.0.3/Object.java:338) at org.netbeans.modules.parsing.impl.TaskProcessor$CurrentRequestReference.setCurrentTask(TaskProcessor.java:1128) - locked <0x00000006d75591d8> (a org.netbeans.modules.parsing.impl.TaskProcessor$CurrentRequestReference$CRRLock) at org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.run(TaskProcessor.java:842) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279) at org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.execute(TaskProcessor.java:702) at org.netbeans.modules.parsing.impl.TaskProcessor$CompilationJob.run(TaskProcessor.java:663) "Module-Actions" apache#163 daemon prio=1 os_prio=0 cpu=2546.95ms elapsed=253.00s tid=0x00007fec806c9c90 nid=0x1abee2 in Object.wait() [0x00007fec951fa000] java.lang.Thread.State: WAITING (on object monitor) at java.lang.Object.wait(java.base@17.0.3/Native Method) - waiting on <no object reference available> at java.lang.Object.wait(java.base@17.0.3/Object.java:338) at javax.swing.text.AbstractDocument.writeLock(java.desktop@17.0.3/AbstractDocument.java:1378) - locked <0x0000000718f28200> (a org.netbeans.modules.editor.NbEditorDocument) at org.netbeans.editor.BaseDocument.extWriteLock(BaseDocument.java:1696) at org.netbeans.editor.BaseDocument.atomicLockImpl(BaseDocument.java:1744) - locked <0x0000000718f28200> (a org.netbeans.modules.editor.NbEditorDocument) - locked <0x0000000718f28200> (a org.netbeans.modules.editor.NbEditorDocument) at org.netbeans.editor.GuardedDocument.runAtomicAsUser(GuardedDocument.java:329) at org.netbeans.modules.editor.lib.BeforeSaveTasks$TaskRunnable.run(BeforeSaveTasks.java:131) at org.netbeans.modules.editor.lib.TrailingWhitespaceRemove.runLocked(TrailingWhitespaceRemove.java:77)

jlahoda added 30 commits September 4, 2018 22:15

A sketch of Java LSP server.

6ee9130

Merge branch 'lsp-client' into java-lsp-server

f71612e

Moving the java.lsp.server module to a correct place.

248c908

Merge branch 'lsp-client' of github.com:jlahoda/incubator-netbeans in…

a233b0f

…to java-lsp-server

Moving the java.lsp.server module to a new location.

40f0e7e

Merge branch 'java-lsp-server' of ssh://lahoda.info:/home/hudson/repo…

3cc62f3

…s/incubator-netbeans into java-lsp-server

Support for JDK 9+.

aeaf1da

Upgrading to LSP4J 5.0

ae13104

Adding support for code actions.

58a290a

Fixing support for keywords in code completion.

44ccc87

Adding outline.

77eaed8

Client sends document content on didOpen.

4af826f

Cleanup - providing a utility to get the appropriate JavaSource.

7ee9903

Adding support for go to declaration to the Java LSP server.

6452108

Adding VS Code extension.

173ae96

Merging recent master branch changes to the java-lsp-server branch

9e7b015

Adjusting dependencies.

10bd959

Starting to eliminate remaining usages of old javadoc API and impleme…

ace411c

…ntation.

Merging recent master changes into the java-lsp-server branch

a0f4b50

Improving the Java server for the LSP.

7666c57

Ensure InstalledFileLocator works by setting cluster path.

e8caa27

Fixing java/javadoc's Analyzer after drop of usage of the old javadoc…

ffe45e3

… API.

Fixing run with OpenJDK project.

7043818

Merged.

48304a8

Resolving forgotten conflicts.

2970f10

Merging recent master branch changes into the no-old-javadoc-api branch.

079d3cc

Automatically add requires.nb.javac when module has a dependency on j…

1cc0f4d

…avacapi.

Not exporting old javadoc API

1c6a2e3

Removing usage of old Javadoc API.

9555694

Merge branch 'no-old-javadoc-api' into java-lsp-server

f987649

jlahoda-jackpot reviewed Mar 23, 2019

View reviewed changes

jlahoda added 18 commits April 28, 2019 22:18

Merging the master branch into the java-lsp-server branch.

997f4c9

Merge branch 'master' into java-lsp-server

3699d0f

Querying source groups sets external source roots, ensuring it is cal…

a62e8b8

…led.

Using DiagnosticSeverity.Warning for Severity.VERIFIER.

f877bcd

Merge branch 'master' into java-lsp-server

eb4216a

Produce correct classpath for langtools tests in the current layout.

e8e18f1

Running the Java language server inside module system.

c2694ec

Merge branch 'master' into java-lsp-server

0156deb

Attempting to fix verify-libs-and-licenses.

fcf3778

Cleanup - undoing unnecessary changes; adding license headers.

3596988

More undoing of unnecessary changes

a949507

Correcting clusters list and configuration.

d77eb88

Adding license info about clusters configuration file (which cannot h…

fe92367

…old license by itself)

Avoiding a StackOverflowError in Tree copier when running on JDK 14 b…

dc68f3a

…y calling the correct superclass method instead of the synthetic bridge.

Check suitable JDK is available, but show an error to the user if not.

02cdcd8

Merging recent master changes into the java-lsp-server branch.

c32a844

Adding a rudimentary README.md

fe0eb7d

Adding a license header.

d727fd4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Testing PR - java.lsp.server #24

Testing PR - java.lsp.server #24

Uh oh!

jlahoda commented Mar 10, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

jlahoda-jackpot Mar 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Testing PR - java.lsp.server #24

Are you sure you want to change the base?

Testing PR - java.lsp.server #24

Uh oh!

Conversation

jlahoda commented Mar 10, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants