test #29
test #29
Conversation
…ent compilation unit - compensating by using positions to find the proper path, also should improve speed.
| throw (ThreadDeath) t; | ||
| } | ||
| boolean a = false; | ||
| assert a = true; |
There was a problem hiding this comment.
Jackpot:
warning: Assert condition produces side effects
| private final Method typeEnterSuperCall; | ||
|
|
||
| public VanillaPartialReparser() { | ||
| Method unenter; |
There was a problem hiding this comment.
Jackpot:
warning: Local variable hides a field
| unenter = null; | ||
| } | ||
| this.unenter = unenter; | ||
| Field lazyDocCommentsTable; |
There was a problem hiding this comment.
Jackpot:
warning: Local variable hides a field
| lazyDocCommentsTable = null; | ||
| } | ||
| this.lazyDocCommentsTable = lazyDocCommentsTable; | ||
| Field parserDocComments; |
There was a problem hiding this comment.
Jackpot:
warning: Local variable hides a field
| parserDocComments = null; | ||
| } | ||
| this.parserDocComments = parserDocComments; | ||
| Method lineMapBuild; |
There was a problem hiding this comment.
Jackpot:
warning: Local variable hides a field
| lineMapBuild = null; | ||
| } | ||
| this.lineMapBuild = lineMapBuild; | ||
| Method typeEnterSuperCall; |
There was a problem hiding this comment.
Jackpot:
warning: Local variable hides a field
| if (a) { | ||
| JavacParser.dumpSource(ci, t); | ||
| } | ||
| t.printStackTrace(); |
There was a problem hiding this comment.
Jackpot:
warning: Print Stack Trace
| // } catch (CouplingAbort ca) { | ||
| // //Needs full reparse | ||
| // return false; | ||
| } catch (Throwable t) { |
There was a problem hiding this comment.
Jackpot:
warning: Can be replaced with multicatch or several catch clauses catching specific exceptions
| } | ||
| if (active && node != null) { | ||
| Integer pos = endPos.replaceTree((JCTree) node, null);//remove | ||
| if (pos != null) { |
There was a problem hiding this comment.
Jackpot:
warning: Unnecessary test for null - the expression is never null
|
|
||
| int noInner; | ||
| boolean hasLocalClass; | ||
| final Set<Tree> docOwners = new HashSet<Tree>(); |
There was a problem hiding this comment.
Jackpot:
warning: Redundant type arguments in new expression (use diamond operator instead).
| import com.sun.source.tree.Tree; | ||
| import com.sun.source.tree.VariableTree; | ||
| import org.netbeans.api.java.source.support.ErrorAwareTreeScanner; | ||
| import com.sun.tools.javac.tree.JCTree.JCClassDecl; |
There was a problem hiding this comment.
Jackpot:
warning: Unused Import
| import com.sun.tools.javac.tree.JCTree.JCClassDecl; | ||
| import java.util.HashSet; | ||
| import java.util.Set; | ||
| import org.netbeans.lib.nbjavac.services.NBTreeMaker.IndexedClassDecl; |
There was a problem hiding this comment.
Jackpot:
warning: Unused Import
| Document doc = ec.openDocument(); | ||
| JavaSource source = JavaSource.forFileObject(src); | ||
| Object[] topLevel = new Object[1]; | ||
| source.runUserActionTask(cc -> { |
There was a problem hiding this comment.
Jackpot:
warning: Dereferencing possible null pointer
| Document doc = ec.openDocument(); | ||
| JavaSource source = JavaSource.forFileObject(src); | ||
| Object[] topLevel = new Object[1]; | ||
| source.runUserActionTask(cc -> { |
There was a problem hiding this comment.
Jackpot:
warning: Dereferencing possible null pointer
| if (!Objects.equals(this.docComment, other.docComment)) { | ||
| return false; | ||
| } | ||
| if (this.kind != other.kind) { |
There was a problem hiding this comment.
Jackpot:
warning: The if statement is redundant
| if (this.kind != other.kind) { | ||
| return false; | ||
| } | ||
| if (!Objects.equals(this.source, other.source)) { |
There was a problem hiding this comment.
Jackpot:
warning: The if statement is redundant
| super(name); | ||
| } | ||
|
|
||
| protected void setUp() throws Exception { |
There was a problem hiding this comment.
Jackpot:
warning: Add @OverRide Annotation
| private final Map<URI,Collection<Symbol.ClassSymbol>> notInProfiles = | ||
| new HashMap<>(); | ||
|
|
||
|
|
There was a problem hiding this comment.
Jackpot:
warning: Field seenPartialReparsePositions can be final
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.logging.Level; | ||
| import java.util.logging.Logger; |
There was a problem hiding this comment.
Jackpot:
warning: Unused Import
| import com.sun.tools.javac.util.Context; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.logging.Level; |
There was a problem hiding this comment.
Jackpot:
warning: Unused Import
| return new NBJavacTrees(c); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Jackpot:
warning: Constant name does not follow naming conventions: hasNbJavac
No description provided.