Skip to content

fixed incorrect internals visible access #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springcomp merged 2 commits into from
Mar 1, 2026
Merged

fixed incorrect internals visible access #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4107713
fixed incorrect internals visible access
springcomp Mar 1, 2026
7914266
fixed compliance tests path
springcomp Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ jobs:
run: dotnet restore jmespath.net.sln

- name: 🔨 Build
run: dotnet build jmespath.net.sln --configuration Release --no-restore
run: dotnet build jmespath.net.sln --configuration Debug --no-restore

- name: 🧪 Run Unit Tests
run: dotnet test tests/jmespathnet.tests/jmespathnet.tests.csproj --no-build --verbosity normal

- name: ✅ Run Compliance Tests
run: dotnet run --project tools/jmespathnet.compliance/jpnet.csproj --no-build
run: dotnet run --project tools/jmespathnet.compliance/jmespathnet.compliance.csproj --no-build -t tools/jmespathnet.compliance/jmespath.test/tests/
4 changes: 0 additions & 4 deletions src/jmespath.net.parser/InternalsVisibleTo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
using System.Runtime.CompilerServices;

#if DEBUG
[assembly: InternalsVisibleTo("jmespathnet.tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100055796df0ae0f975fabb3455d92c9edfef1e266fe66273a7f42c298406335fef71fdf99f46033f5f1e890fa2c6a5f230bfdd5832aa16eb45af02ad70ff716f97a51ff955abaaa2490da59ece7f2474dd43695c6bc8f1c82d1bb38f166fdfa7716e11291bda347bc8689d5435e68401a9ab5b4e8e49c1074173d21edf4fbda1b1")]
#else
[assembly: InternalsVisibleTo("jmespathnet.tests, PublicKey=002400000480000094000000060200000024000052534131000400000100010055709b8bb177721db5eb5a9e7437bfa5f46251aef5dcf91f4a36a7dcb98e51a8ecf5a37284004fa6694f3471f5dfc82244c9672eb085cd65c7cb75d8251aa971a349d4641b492ca0963b74fd9878a5872d6ccbb7b7ceff82aa3687c240a70b4d5565c7cff5df0a12cdbde58e937320fb302b7ccedff72008f3bec0bee8384dc5")]
#endif
4 changes: 0 additions & 4 deletions src/jmespath.net/InternalsVisibleTo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
using System.Runtime.CompilerServices;

#if DEBUG
[assembly: InternalsVisibleTo("jmespathnet.tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100055796df0ae0f975fabb3455d92c9edfef1e266fe66273a7f42c298406335fef71fdf99f46033f5f1e890fa2c6a5f230bfdd5832aa16eb45af02ad70ff716f97a51ff955abaaa2490da59ece7f2474dd43695c6bc8f1c82d1bb38f166fdfa7716e11291bda347bc8689d5435e68401a9ab5b4e8e49c1074173d21edf4fbda1b1")]
#else
[assembly: InternalsVisibleTo("jmespathnet.tests, PublicKey=002400000480000094000000060200000024000052534131000400000100010055709b8bb177721db5eb5a9e7437bfa5f46251aef5dcf91f4a36a7dcb98e51a8ecf5a37284004fa6694f3471f5dfc82244c9672eb085cd65c7cb75d8251aa971a349d4641b492ca0963b74fd9878a5872d6ccbb7b7ceff82aa3687c240a70b4d5565c7cff5df0a12cdbde58e937320fb302b7ccedff72008f3bec0bee8384dc5")]
#endif
6 changes: 3 additions & 3 deletions tests/jmespathnet.tests/jmespathnet.tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp3.1;net452;net6.0</TargetFrameworks>
<TargetFrameworks>net452;net6.0</TargetFrameworks>
<AssemblyName>jmespathnet.tests</AssemblyName>
<PackageId>jmespathnet.tests</PackageId>
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
Expand All @@ -17,7 +17,7 @@
<ProjectReference Include="..\..\src\jmespath.net.parser\jmespath.net.parser.csproj" />
<ProjectReference Include="..\..\src\jmespath.net\jmespath.net.csproj" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp3.1'">
<ProjectReference Include="..\..\src\jmespath.net.parser\jmespath.net.parser.csproj" AdditionalProperties="TargetFramework=netstandard1.3"/>
<ProjectReference Include="..\..\src\jmespath.net\jmespath.net.csproj" AdditionalProperties="TargetFramework=netstandard1.3"/>
Expand All @@ -29,4 +29,4 @@
<PackageReference Include="xunit" Version="2.4.0" />
</ItemGroup>

</Project>
</Project>
Loading