Skip to content

Fix TypeError on ordering comparison between string and number #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bysiber wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −3
Open

Fix TypeError on ordering comparison between string and number #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions jmespath/visitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,10 @@ def visit_comparator(self, node, value):
# will yield a None value.
left = self.visit(node['children'][0], value)
right = self.visit(node['children'][1], value)
num_types = (int, float)
if not (_is_comparable(left) and
_is_comparable(right)):
if not ((_is_actual_number(left) and
_is_actual_number(right)) or
(isinstance(left, string_type) and
isinstance(right, string_type))):
return None
return comparator_func(left, right)

Expand Down