Type-check extra arguments to variadic functions#348
Open
bysiber wants to merge 1 commit intojmespath:developfrom
Open
Type-check extra arguments to variadic functions#348bysiber wants to merge 1 commit intojmespath:developfrom
bysiber wants to merge 1 commit intojmespath:developfrom
Conversation
_type_check only iterates over range(len(signature)). For variadic
functions like merge() where the signature has a single entry with
variadic=True, only the first argument is type-checked. Extra arguments
bypass validation entirely, causing raw Python exceptions (ValueError,
TypeError) instead of JMESPathTypeError.
For example: merge(`{"a":1}`, `"not_a_dict"`) raises ValueError
('dictionary update sequence element #0 has length 1') instead of
JMESPathTypeError.
Fix: after the normal loop, check additional variadic arguments against
the last signature entry's type constraints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_type_checkonly validates the first N arguments where N is the length of the function signature. For variadic functions likemerge(), the signature has a single entry withvariadic: True, so only the first argument is type-checked. All extra arguments bypass validation entirely.The fix adds a second loop after the normal signature check that validates the extra variadic arguments against the last signature entry's type constraints.