Add integration tests by joaoguazzelli · Pull Request #37 · joaoguazzelli/spire

joaoguazzelli · 2022-10-04T23:25:29Z

No description provided.

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

…nt from nil and if so the sigstore configuration function is called. Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

…trings (#38) Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Co-authored-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

) Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

…illallves#49) Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* feat: adding option to enable sigstore functions Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed enable variable if clause Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * docs: updated documentation on sigstore toggle Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * feat: moved sigstore options to experimental section Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * docs: updated docs for experimental k8s options Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* refactor: refactoring the configureSigstore function in k8s_posix.go file Signed-off-by: Matheus Santos <mfcs@cesar.org.br> * refactor: refactored rekor URL tests and added more test cases Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Co-authored-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* fix: added label to log line Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * feat: added telemetry tag for container name Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * logs: added container name telemetry label to log line Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed sigstore config on some tests Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed URL empty checking before config as the error is handled in config Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* Refactory on k8s unit tests Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * Fixed: Refactory on k8s unit tests Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * Fixed: Refactory on k8s unit tests for windows Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * Fixed: Refactory on k8s unit tests for windows 0 Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * Fixed: Refactory on k8s unit tests for windows 1 Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

…on (willallves#67) Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Co-authored-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

…llves#81) * refactor: changed DeepEqual to require.Equal and other changes Signed-off-by: Matheus Santos <mfcs@cesar.org.br> * refactor: deleted blank line Signed-off-by: Matheus Santos <mfcs@cesar.org.br> * refactor: added a blank line in the end of the file Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Co-authored-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

willallves#88) refactor: pr requests to change from deepEqual to require.Equal, remove some code from k8s_test file and refactor an error message in sigstorecache_test file Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Co-authored-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* Added test case for last element added as first of list Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * tests: removed parallel call to t.Run on sequential tests Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: added longer sequence of tests and checks Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: refactored TestNewCache to not use multiple test case syntax for a single test case Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

…illallves#107) * fix: refactoring so sigstore errors make attestation fail completely Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: fixed lint complain Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: moved new requireAttestFailureWithPod test helper function to k8s_posix_test.go, fixing windows linting Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

…llallves#112) Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* refactor: used oci.Signature instead of v1.Layer, and removed unneeded nil functions Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: streamlined returns Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: removed unused functions for error signature types Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: refactored TestNew and added fail messages Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: refactored New tests Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * test: added function mock factory functions Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: placed deepEqual usage in TestSigstoreimpl_FetchImageSignatures Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: added argument testing for mock functions in TestSigstoreimpl_FetchImageSignatures Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: added a comment. Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: added error value checking to TestSigstoreimpl_FetchImageSignatures Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: added error and arg checking on TestSigstoreimpl_ValidateImage Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: refactored function mocks Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed fail functions Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: added error and args checking to TestSigstoreimpl_AttestContainerSignatures Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: added error checking on SetRekorURL Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: moved signature types and helper functions to end of file Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: added extra test cases to TestSigstoreimpl_ClearAllowedSubjects Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: fixing trailing newlines and comment spacing Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed trailing newline Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* refactor: refactored external function hooks into single field Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: added checkOpts argument checking to TestSigstoreimpl_FetchImageSignatures refactor: moved functions to hook struct in TestSigstoreimpl_FetchImageSignatures Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* fix: added error return to AttestContainerSignatures method * fix: changed variable from camel to snake case * fix: add returned type to error message in getBundleSignatureContent method * fix: changed log from camel to snake case * fix: fixed nil payload test case * fix: fix import order * fix: sync with remote * fix: change import order Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* refactor: added error checking on checkOpts handling tests: added checkOpts checking to TestSigstoreimpl_AttestContainerSignatures Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: added empty rekorURL test case to TestSigstoreimpl_AttestContainerSignatures Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix:removed unused function Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

…errors (willallves#121) * logs: added container id to SelectorValuesFromSignature log lines Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: refactored SelectorValuesFromSignature to error out on all errors Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* draft private functions Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * Refactory getBundle private Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * Refactory getSubject private Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * remove test case repeat Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* tests: removed typecast usage for sigstoreMock Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests:removed usage of contains on skipped and allowed lists Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed TestConfigure for skippedImages and AllowedSubjects lists Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* draft private functions Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * Refactory getBundle private Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * Refactory getSubject private Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * remove test case repeat Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> * refactor: refactored SelectorValuesFromSignature to return errors instead of logging tests: added error checking to SelectorValuesFromSignature testinng Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

* test: add hashed manifest test case Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com> * fix: fixed lint error Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com> * fix: removed duplicated test cases Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com> Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>

Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>

joaoguazzelli force-pushed the main branch from f4b058d to d4372be Compare October 4, 2022 23:31

joaoguazzelli force-pushed the add-integration-tests branch from 903e5c4 to 5af4587 Compare October 4, 2022 23:41

willallves and others added 28 commits October 4, 2022 20:48

Added Sigstore workload attestor for SPIRE

fcb5722

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Fix hcl on k8s tests

1f0d339

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Adjust on log message

36e45e9

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Adjust lint error

c5bebad

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

removed unnecessary code

adae94c

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

refactor: A check has been created to verify if p.sigstore is differe…

f46329f

…nt from nil and if so the sigstore configuration function is called. Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

fix: fixed lint errors

f3b79bd

Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

fix: fixed lint errors

ead4c2c

Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

fix: fixed lint errors

c0afd10

Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

refactor: pr adjustments related to cosign

a296371

Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

refactor: pr adjustments of logs of errors

95f79a7

Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

refactor: pr adjustments of logs for errors

3f8a6a6

Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

fixing CI error

7985cd5

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

dependency test

97542d1

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

progress: solving dependency errors, apply marcos diff (#36)

66208ec

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

PR adjustments of code organization and change imageID to a list of s…

2978f01

…trings (#38) Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

feat: adding plugin mutex lock to configureSigstore. (#37)

b7fc703

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

SelectorsFromSignature pointer refactor (#33)

5eb944e

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

K8s test refactor (#43)

5bf47f7

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Moving the initial state of sigstore on suite to setup (#40)

458747f

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

refactor: refactor of sigstorecache code (#44)

b997cc6

Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Co-authored-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Refactor of ValidateImage and validateRefDigest functions (willallves#48

5580709

) Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

refactor: refactor of sigstore.go code related to subject assignment (w…

06306eb

…illallves#49) Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Removed RFC doc link (willallves#57)

f8ef633

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Fixed dependencies

8e861d0

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

willallves and others added 24 commits October 4, 2022 20:49

Update doc/plugin_agent_workloadattestor_k8s.md

a6a9926

Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Removed unnecessary code (willallves#99)

f9dc801

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Added rekor text in docs (willallves#101)

18eee2f

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

tests: removed repeated tests of failing parsing rekorURL on mock (wi…

da26276

…llallves#112) Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Fixed shorts comments (willallves#114)

aedcbb3

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

fix: fixed lint errors

4af1423

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

cosign v1.9.0 for v1.12.1

96ecc8e

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

Move sigstore out of windows build (willallves#150)

1e548a5

Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>

Added integration tests Sigstore workload attestor for SPIRE

0052820

Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com>

joaoguazzelli force-pushed the add-integration-tests branch from 5af4587 to 0052820 Compare October 4, 2022 23:57

joaoguazzelli pushed a commit that referenced this pull request Oct 14, 2022

feat: adding plugin mutex lock to configureSigstore. (#37)

611c7c2

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

joaoguazzelli pushed a commit that referenced this pull request Oct 17, 2022

feat: adding plugin mutex lock to configureSigstore. (#37)

22cfe85

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

joaoguazzelli pushed a commit that referenced this pull request Oct 18, 2022

feat: adding plugin mutex lock to configureSigstore. (#37)

240ac87

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>

joaoguazzelli pushed a commit that referenced this pull request Nov 10, 2022

feat: adding plugin mutex lock to configureSigstore. (#37)

1e7b755

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>

joaoguazzelli pushed a commit that referenced this pull request Nov 23, 2022

feat: adding plugin mutex lock to configureSigstore. (#37)

26c469f

Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Add integration tests#37

Add integration tests#37
joaoguazzelli wants to merge 56 commits intomainfrom
add-integration-tests

joaoguazzelli commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

joaoguazzelli commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants