Dynamic signal tune selection for hourly chime, alarm, and countdown timer#150
Open
imihajlow wants to merge 7 commits intojoeycastillo:mainfrom
Open
Dynamic signal tune selection for hourly chime, alarm, and countdown timer#150imihajlow wants to merge 7 commits intojoeycastillo:mainfrom
imihajlow wants to merge 7 commits intojoeycastillo:mainfrom
Conversation
|
This is a great idea! On the previous Movement firmware, there was someone who also implemented quiet hours, so the chimes don't ring at night. Was never added to main, but perhaps a nice addition to your watch face? I would be thrilled to see this combined with your code. Just an idea though! |
Author
|
@PieterJanSterk I believe a pull request should cover one thing at a time, combining tune selection with quiet hours doesn't seem like a good idea for me. And the pull requests here barely get merged anyway, getting an even bigger PR merged will be even less realistic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: I want to be able to select custom signal tunes. I also find alarm and timer signals too short.
All existing signal tunes are made available in an array, two more simple tunes added. Signal tune configuration data structure is introduced (see movement_signal_tunes.h) which lets you configure tune, playback duration and interval between repetitions.
All constant tune data is made
constto save RAM.It is now possible to automatically repeat a tune (see
watch_buzzer_play_sequence_repeat) to make alarms longer.A new Signal Tunes watch face lets user select tune for each slot (chime, alarm, timer). Light button switches between slots, Alarm button selects tunes.