Make it possible to have local overrides without changing movement_config.h#177
Open
eiriksm wants to merge 1 commit intojoeycastillo:mainfrom
Open
Make it possible to have local overrides without changing movement_config.h#177eiriksm wants to merge 1 commit intojoeycastillo:mainfrom
eiriksm wants to merge 1 commit intojoeycastillo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the motivation for this is like follows:
Personally, and based on the discord, I build my firmware from a fork of this repo, which I try to keep up to date. One of the sources for merge conflicts is changes to the file
movement_config.h.So, coming from a web background. What one usually do to have local overrides in your environment is to have a local env file, that would take precedence over the commited one. For configuration, basically.
So that's the idea behind this PR. Make it possible to customize the faces, and the settings. Without actually having to edit the checked in file
movement_config.h.This would also make it easier to maintain different branch forks. For example, I have one branch for my wife, and one branch for me. We have different preferences in terms of watch faces and config.
Lastly. This would also be kind of useful for the online builder. Would make a cleaner implementation (in my opinion).