Skip to content

Added new face: Pomodoro Timer#83

Open
Alfedi wants to merge 16 commits intojoeycastillo:mainfrom
Alfedi:main
Open

Added new face: Pomodoro Timer#83
Alfedi wants to merge 16 commits intojoeycastillo:mainfrom
Alfedi:main

Conversation

@Alfedi
Copy link

@Alfedi Alfedi commented Aug 10, 2025

Based on the legacy Tomato face and in the Countdown face, I made a simple pomodoro timer with pause, reset, and the possibility to change the timers between a given set of times.

@Alfedi
Copy link
Author

Alfedi commented Aug 10, 2025

I just realize that I left some things undone, like the low energy behaviour and the cleaning of the code. Marking this as draft and I will try to get things done as soon as I can.

@Alfedi Alfedi marked this pull request as draft August 10, 2025 14:36
@Alfedi
Copy link
Author

Alfedi commented Aug 12, 2025

Now I believe it's completed. Waiting for review :)

@Alfedi Alfedi marked this pull request as ready for review August 12, 2025 12:14
@voloved
Copy link
Collaborator

voloved commented Nov 21, 2025

Now I believe it's completed. Waiting for review :)

I looked over the main code and it looks fine to me.
Have you had any issues with it or anything else before I pull it in?

@Alfedi
Copy link
Author

Alfedi commented Dec 1, 2025

No, I have been using it in my sensorwatch without any problem.

@voloved
Copy link
Collaborator

voloved commented Dec 2, 2025

@Alfedi ,

Can you fix this warning?

watch-faces/complication/pomodoro_face.c: In function '_pomodoro_face_update_lcd':
watch-faces/complication/pomodoro_face.c:84:29: warning: '%02d' directive writing between 2 and 3 bytes into a region of size between 1 and 3 [-Wformat-overflow=]
watch-faces/complication/pomodoro_face.c:84:20: note: directive argument in the range [0, 255]
watch-faces/complication/pomodoro_face.c:84:5: note: 'sprintf' output between 7 and 10 bytes into a destination of size 7

@Alfedi
Copy link
Author

Alfedi commented Jan 26, 2026

Finally had time to check this. Warning should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants