Refactor Source to use fs.FS under the hood.#12
Open
SpeedyCoder wants to merge 2 commits intojohngibb:masterfrom
Open
Refactor Source to use fs.FS under the hood.#12SpeedyCoder wants to merge 2 commits intojohngibb:masterfrom
SpeedyCoder wants to merge 2 commits intojohngibb:masterfrom
Conversation
added 2 commits
November 22, 2021 10:53
This will allow users to pass in any FS implementation. For example `embed.FS`, that allows usage of embedded migration files. Given that fs.FS is read only I had to modify the Create functionality. I've removed the method from the Source struct and moved the logic into the Create function and changed its signature to take path instead of Source struct. This is only a helper function, so I think even though it's a breaking change it should be fine to make.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users to pass in any FS implementation. For example
embed.FS,that allows usage of embedded migration files. Given that fs.FS is read only
I had to modify the Create functionality. I've removed the method from the Source
struct and moved the logic into the Create function and changed its signature to
take path instead of Source struct. This is only a helper function, so I think
even though it's a breaking change it should be fine to make.