Do not use field selector in makeWorld#139
Merged
dpwiz merged 2 commits intojonascarpay:masterfrom Oct 2, 2025
Merged
Conversation
- Switch generate data type to normal constructor instead of record - Use handwritten accessor instead This means generated code will work with NoFieldSelectors on. Fixes jonascarpay#137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
NoFieldSelectorsis active selectors are not generated and usingmakeWorldresults in compilation error. This PR replaces field selectors with handwritten accessors and switch world's constructor from record to normal constructor.I took liberty to rewrite TH to use quasiquotes extensively
Fixes #137