You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks, those seem like good changes overall!
For the separator though, I think with @ckardaris' changes from #8 the idea was to have an empty entry correspond to a separator though. So I think you can just look for an empty menu string and insert a separator for those?
I predict most users will think of "------------" as a separator before they will think of a blank entry. It also provides an easier item to discover when scanning the input string visually. I strongly recommend leaving that option available.
I think it's unlikely that a user will know to use exactly as many - as required. They will have to look for "separator" in the help, at which point learning about the empty string is just as easy as learning about the ---- pattern, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.