Open
Conversation
* Added generic extension method Contains in Array to chech if an object is included in an array
Owner
|
Thanks for this pull request! I'll review it and merge shortly |
Author
|
Ok i'll be happy. I'm also a contributor in the ruby version. .Net addicted i could not miss this. |
Owner
|
Ok, so I've been thinking about this a bit more. How would you feel about something like this: As opposed to having a different class for each country? I was looking at how ffaker does it in ruby, and they appear to have taken your approach, which would keep it more consistent. However, doing something like the above would really cut down on the amount of code that is needed. |
Author
|
+1 for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.