Added EU type street address#5
Open
rikvanmechelen wants to merge 5 commits intojonwingfield:masterfrom
Open
Conversation
Signed-off-by: PulsarBlow <pulsarblow@gmail.com>
Signed-off-by: PulsarBlow <pulsarblow@gmail.com>
Added the EU type street address (or at least part of the EU, which has:
{street name} {house number} {secondary address}
I also changed some line endings to the default windows line endings
(VS.net asked met to do so)
…of # Without the join, it will just call ToString(), which gives something along the lines of: Faker.Extensions.NumberExtensions+<Times>d__5`1[System.String]275 Salma Divide Suite 548 for a US street address. Additionally the Join is changes to return the empty string in case the IEnumerable is empty (it crashes otherwise)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started from PulsarBlow/Faker.Net and created a distinction between us address formatting and eu street address formatting (more particularly, street formatting).
Most EU countries have: {street name} {house number} {extra stuff, such as Apt} while in the us, you start with the street address.
there seem to be some extra's this merge that come from PulsarBlow/Faker.Net