This repository was archived by the owner on Jul 28, 2020. It is now read-only.
Fixed issue #133, templates file upload folder selection issue.#134
Open
ahamed wants to merge 2 commits intojoomla-projects:masterfrom
Open
Fixed issue #133, templates file upload folder selection issue.#134ahamed wants to merge 2 commits intojoomla-projects:masterfrom
ahamed wants to merge 2 commits intojoomla-projects:masterfrom
Conversation
Contributor
|
The changes here can not be correct. You should not have to be making changes to the upstream files when they work perfectly with atum. The fact you need to change them is indicative of a problem in the template code and not in the system code |
Contributor
Author
|
We used |
Contributor
|
great that you are using the webcomponent but that doesnt change my comment |
ahamed
commented
Dec 3, 2019
Contributor
Author
ahamed
left a comment
ahamed
left a comment
There was a problem hiding this comment.
Add extra newline.
|
I don't see what happen when click on folder as: select the folder and toggle its descendants. |
|
Now, I can upload a new file but could not indicate the folder inside. It is in the root @ahamed07sajeeb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #133 .
Summary of Changes
This pull request fixes template file upload modal's folder selection issue. And also improve
scss.Testing Instructions
Go to `Extensions > Templates > On Cassiopeia template click Edit Files > Click New File
Expected result
At the left side folder tree by clicking on a folder should select the folder and toggle its descendants.
Actual result
It reloaded the page by clicking on the folders.
Documentation Changes Required