This repository was archived by the owner on Jul 28, 2020. It is now read-only.
Improve available update percent count calculation.#144
Open
ahamed wants to merge 1 commit intojoomla-projects:masterfrom
Open
Improve available update percent count calculation.#144ahamed wants to merge 1 commit intojoomla-projects:masterfrom
ahamed wants to merge 1 commit intojoomla-projects:masterfrom
Conversation
…xtensions from the calculationof total extensions count
Contributor
|
There is a bug. |
|
@ahamed07sajeeb get the same error like kawshar' test. Fix the error by adding "static" keyword to 2 functions you created: getExtensions and getTotalExtensions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #115.
Summary of Changes
Changes the available updates calculation. Remove the core extensions from the Total Installed Extensions count. Now the Joomla! core and core extensions take 50% of the system update count and other non-core extensions take the remaining 50% count.
Testing Instructions
Go to Dashboard and check the
Available updatesmodule. Install an outdated extension and check the percentage value.