This repository was archived by the owner on Jul 28, 2020. It is now read-only.
Fix #113 issue: mod_quickicon missing strings #113#153
Open
davidnguyen-joomlashine wants to merge 1 commit intojoomla-projects:masterfrom
Open
Fix #113 issue: mod_quickicon missing strings #113#153davidnguyen-joomlashine wants to merge 1 commit intojoomla-projects:masterfrom
davidnguyen-joomlashine wants to merge 1 commit intojoomla-projects:masterfrom
Conversation
brianteeman
reviewed
Dec 9, 2019
Contributor
brianteeman
left a comment
brianteeman
left a comment
There was a problem hiding this comment.
This is obviously not correct. Why would you have text that is set be displayed only to screen readers that is identical to text that is set to be hidden from screen readers?
Author
|
@brianteeman I checked and see that "sr-only" presents actions: View all Users, View all Menu Items View all Articles and View all Modules, so I thought it makes sense if it is identical to text that be hidden from screen readers. Please let me know if I missed something. Thank you so much |
Contributor
|
Think about it for a second. Why would you hide text and then choose to display the exact same text |
Author
|
@brianteeman I think it is not necessary, so it should be removed out. What do you think of my idea. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #113
Summary of Changes
Fix JText string
Testing Instructions
Expected result
Actual result
Documentation Changes Required